Fix check for function wddx_deserialize in tests for hhvm
authorumherirrender <umherirrender_de.wp@web.de>
Wed, 10 Dec 2014 20:09:36 +0000 (21:09 +0100)
committerBryanDavis <bdavis@wikimedia.org>
Wed, 10 Dec 2014 22:25:25 +0000 (22:25 +0000)
The @requires just works for other tests, not for php functions.

This fixed a failure for the hhvm test server:
1) ApiFormatWddxTest::testValidSyntax
Failed asserting that null is of type "array".

Change-Id: Iadd8238ce62d4803cdf56508886ad016f8ac8f1d

tests/phpunit/includes/api/format/ApiFormatWddxTest.php

index d075f54..5170856 100644 (file)
@@ -8,10 +8,11 @@
  */
 class ApiFormatWddxTest extends ApiFormatTestBase {
 
-       /**
-        * @requires function wddx_deserialize
-        */
        public function testValidSyntax( ) {
+               if ( !function_exists( 'wddx_deserialize' ) ) {
+                       $this->markTestSkipped( "Function 'wddx_deserialize' not exist, skipping." );
+               }
+
                $data = $this->apiRequest( 'wddx', array( 'action' => 'query', 'meta' => 'siteinfo' ) );
 
                $this->assertInternalType( 'array', wddx_deserialize( $data ) );